Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

[feature] to support API call with go client pkg #271

Closed
chinglinwen opened this issue Aug 2, 2019 · 2 comments
Closed

[feature] to support API call with go client pkg #271

chinglinwen opened this issue Aug 2, 2019 · 2 comments

Comments

@chinglinwen
Copy link

chinglinwen commented Aug 2, 2019

This is a feature request.

to support update config by API, rather than change config and do restart.

I expect a service that support API call, which I can use Golang client package to do the call, to update/add/delete ( probe item ), may also update local config file at the same time( so latest config survival process restart ).

@chinglinwen
Copy link
Author

chinglinwen commented Aug 5, 2019

As the new release v0.10.4, Cloudprobe support Dynamic configuration via gRPC service.

by reading this code https://sourcegraph.com/github.com/google/cloudprober/-/blob/prober/prober.go#L86:19

I think Cloudprobe doesn't support persistent config for now?

@manugarg
Copy link
Contributor

@chinglinwen That's correct. Cloudprober doesn't persist config changes. It becomes really tricky to do both -- dynamic reconfiguration as well as persistence. We can probably do something along the lines of checkpointing, but maintaining and cleaning up checkpoints is also tricky.

Currently the expectation is that the client software will maintain the config and will recreate (if cloudprober dies for some reason) cloudprober with the latest config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants