This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Consider always returning unique targets through targets.ListEndpoints() #445

Closed

manugarg opened this issue Aug 7, 2020 · 0 comments

Contributor

manugarg commented Aug 7, 2020 •

edited

Loading

Duplicate targets can cause spurious behavior in probes. See #436 for example.

We have changed RDS client to never return duplicate targets, however it may make sense to implement this logic in targets.ListEndpoints():

cloudprober/targets/targets.go

Line 178 in 117d1e1

func (t *targets) ListEndpoints() []endpoint.Endpoint {

manugarg mentioned this issue

Duplicate targets can mangle HTTP probe results. #436

Closed

manugarg closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.