Add stats parsing for honggfuzz. #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
inferno-chromium
approved these changes
Nov 8, 2019
| stats = {} | ||
|
|
||
| for part in parts: | ||
| key, value = part.split(':', 2) |
There was a problem hiding this comment.
should we bail out if ':' not in part ? just to avoid exception, maybe log_error ?
| try: | ||
| stats[key] = int(value) | ||
| except (ValueError, TypeError): | ||
| logs.log_error('Invalid stat value', value=value) |
There was a problem hiding this comment.
end with period, add key=key in arguments too.
| break | ||
| stats = _get_stats(line) | ||
|
|
||
| if stats is None: |
There was a problem hiding this comment.
you need to initialize stats var too, otherwise can end up with var not defined.
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1128