Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in offline-search.js #305

Closed
cdhunt opened this issue Jul 8, 2020 · 2 comments · Fixed by #313
Closed

Typo in offline-search.js #305

cdhunt opened this issue Jul 8, 2020 · 2 comments · Fixed by #313

Comments

@cdhunt
Copy link

cdhunt commented Jul 8, 2020

It looks like the div class is correctly named offline-search-result, but the script is referencing offlnie-search-max-results.

I haven't noticed any unexpected behavior in offline search functionality, though.

$targetSearchInput.data('offlnie-search-max-results')

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 22, 2020

@tekezo, could you take a look?

@tekezo
Copy link
Contributor

tekezo commented Jul 22, 2020

Thank you for feedback!
I checked the code, both div class and javascript were misspelled, so there was no problem with the behavior.

I made a PR to fix this typo.
#313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants