Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the explicit dependency on rules_cc. #235

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Remove the explicit dependency on rules_cc. #235

merged 1 commit into from
Nov 13, 2024

Conversation

BYVoid
Copy link
Contributor

@BYVoid BYVoid commented Nov 13, 2024

In general, cc_library and cc_test do not need an explicit load. By removing it, we can remove the explicit dependency to rules_cc in MODULE.bazel. This makes the dependency management easier. Nothing should be broken by this change.

floitsch
floitsch approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@floitsch
Copy link
Collaborator

Thanks.

@floitsch floitsch merged commit 2d657b9 into google:master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BYVoid @floitsch