-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generating webpackable packages #1547
Conversation
@JustinBeckwith This is now ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/nits. Have you run the generator to make sure the resulting output looks right? From a process perspective:
- Please run the generator against master, and submit a PR with any changes
- After that lands, let's land this PR
- Let's follow up with a PR that includes just the generated changes from this PR
This complicated process is exactly the reason why I suggest that generator should live outside of this library, being a devDependency :) #1554 shows the changes to all APIs. |
Generating small packages that are:
AuthPlus
is re-exported fromgoogleapis-common
to make it available for users).