MOE Sync 2020-03-16

[cpovirk]

This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.

Commits:

Migrate from JSR-305 to the Checker Framework annotations

this is tangentially related to Java 11 preparedness.

dac42f8

[sormuras]

this is tangentially related to Java 11 preparedness.

Including supporting new syntax elements (Java language features) as collected in #436?

[cpovirk]

Not sure what @cushon has in store, but CCing him in case he has anything to say.

[sormuras]

Missed him at FOSDEM and the OCW in Brussels in early February.

[cushon]

The language level changes in 11 (var, private interface methods) don't affect the parser/AST and should already be supported, and the features discussed in #436 were added or previewed after 11.

Supporting Java > 11 is still future work. In particular, there isn't an obvious way to do it without burning compatibility with Java <= 11 (which we aren't ready to do yet) or maintaining branches for each JDK release (which could happen but isn't free).

[sormuras]

[...] maintaining branches for each JDK release (which could happen but isn't free).

Copied from https://twitter.com/BrianGoetz/status/1221884070155735040

I think you've still missed the point, which is: what you're wishing for, while reasonable, is far more costly than you're imagining.
Absent a serious effort to find a sponsor willing to underwrite this expense (for many years), is there more here than "I want a pony"?

I still want that pony -- and am interested in helping out on that case.