Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert polynomial coefficient type to use modarith #1096

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from
Draft

Convert polynomial coefficient type to use modarith #1096

wants to merge 48 commits into from
+1,383 −994

Commits on Nov 20, 2024

  1. update mlir::polynomial -> mlir::heir::polynomial and start migrating

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    05e1775 View commit details
    Browse the repository at this point in the history

  2. migrate polynomial off coefficientType

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c4f1a69 View commit details
    Browse the repository at this point in the history

  3. migrate tests off coefficientType

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c6f7cd0 View commit details
    Browse the repository at this point in the history

  4. copy some more tests from upstream

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3210e8f View commit details
    Browse the repository at this point in the history

  5. modarith -> mod_arith

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    80cf66d View commit details
    Browse the repository at this point in the history

  6. try fixing polynomial patterns and op arg types

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    07e6b11 View commit details
    Browse the repository at this point in the history

  7. fix some more tests

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    994afa7 View commit details
    Browse the repository at this point in the history

  8. fix lwe-to-polynomial conversion

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a8b06c6 View commit details
    Browse the repository at this point in the history

  9. fix polynomial fromtensor builders and verifiers

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c914b60 View commit details
    Browse the repository at this point in the history

  10. fix tests broken by syntax or missing mod_arith dep

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4eb3d34 View commit details
    Browse the repository at this point in the history

  11. fix more tests for mod_arith check lines

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3c977c6 View commit details
    Browse the repository at this point in the history

  12. fix a test for from_tensor type change

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3f740c2 View commit details
    Browse the repository at this point in the history

  13. fix mod_arith conversions in ntt benchmark

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ef43489 View commit details
    Browse the repository at this point in the history

  14. fix canonicalization test and use signed printer

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    28488f8 View commit details
    Browse the repository at this point in the history

  15. fix two tests to align from_tensor types

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e9bfece View commit details
    Browse the repository at this point in the history

  16. change test from a parser error to an impl-needs-update error

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3bb2c87 View commit details
    Browse the repository at this point in the history

  17. fix LWEToPolynomial

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    26839f8 View commit details
    Browse the repository at this point in the history

  18. fix bad regex breaking test

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3d5d4ea View commit details
    Browse the repository at this point in the history

  19. start fixing polynomial-to-llvm

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    94e9756 View commit details
    Browse the repository at this point in the history

  20. fix lower_add, lower constant and add to mod_arith

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d462816 View commit details
    Browse the repository at this point in the history

  21. mod_arith.mod_arith -> mod_arith.int

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    49a7a9b View commit details
    Browse the repository at this point in the history

  22. fix storage type on two tests

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c4842e2 View commit details
    Browse the repository at this point in the history

  23. allow toTensor to use AnyType for elt ty

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    54e24e5 View commit details
    Browse the repository at this point in the history

  24. add mod_arith lowering to poly-to-llvm pipeline

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    db1878e View commit details
    Browse the repository at this point in the history

  25. use mod arith in lower_add_runner

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    68e9cf4 View commit details
    Browse the repository at this point in the history

  26. augment lower_add for mod_arith

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    115067e View commit details
    Browse the repository at this point in the history

  27. convert lower_intt and runner test

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5c7f63e View commit details
    Browse the repository at this point in the history

  28. more coefficientModulus syntax removal

    @j2kun
    j2kun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    fba5c84 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. convert lower_leading_term

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b6788e2 View commit details
    Browse the repository at this point in the history

  2. lower monomial to mod_arith

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8a1a103 View commit details
    Browse the repository at this point in the history

  3. fix test for lower_monomial_mul

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3f85a83 View commit details
    Browse the repository at this point in the history

  4. lower to_tensor to mod_arith

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5e1e717 View commit details
    Browse the repository at this point in the history

  5. reduce scope of one test to test type lowering only

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e622522 View commit details
    Browse the repository at this point in the history

  6. migrate lower_mul_scalar

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b27e56f View commit details
    Browse the repository at this point in the history

  7. convert lower_ntt

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    60bf141 View commit details
    Browse the repository at this point in the history

  8. migrate lower_ntt

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7ed7d91 View commit details
    Browse the repository at this point in the history

  9. start converting ConvertMul to mod_arith

    @j2kun
    j2kun committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ad550d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. migrate lower_mul

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    793aceb View commit details
    Browse the repository at this point in the history

  2. lower ModArith.constant, convert lower_mul_runner

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    69f47e3 View commit details
    Browse the repository at this point in the history

  3. fix some, but not all, lower_mul runner tests

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    408890c View commit details
    Browse the repository at this point in the history

  4. fix lower_ntt_perf_runner

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b174779 View commit details
    Browse the repository at this point in the history

  5. fix ntt_benchmark

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    7b20069 View commit details
    Browse the repository at this point in the history

  6. Fix more tests by removing sub canonicalization 

    Replacing x-y with x + -1*y started breaking things because the constant
-1, when inserted into a mod arith type as a mod_arith.constant, was
being represented internally as -1 : i32, which for test_mul_1 caused it
to be one larger than the modulus (which was 2**31 - 1), i.e., zero,
which resulted in an infinite loop.
    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    239fabb View commit details
    Browse the repository at this point in the history

  7. fix materialization of negative constants

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e20d695 View commit details
    Browse the repository at this point in the history

  8. fix remaining tests

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9bef19e View commit details
    Browse the repository at this point in the history

  9. polynomial-to-standard -> polynomial-to-mod-arith

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b1ce8f4 View commit details
    Browse the repository at this point in the history

  10. rename PolynomialToStandard -> PolynomialToModArith

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    fd37924 View commit details
    Browse the repository at this point in the history

  11. add TODO

    @j2kun
    j2kun committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    3d1386e View commit details
    Browse the repository at this point in the history