add a ModArith constant op #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asraa
approved these changes
Nov 19, 2024
AlexanderViand-Intel
approved these changes
Nov 19, 2024
lib/Dialect/ModArith/Conversions/ModArithToArith/ModArithToArith.cpp
Outdated
Show resolved
Hide resolved
This custom-parsed op and attribute make it relatively easy to
systematically change an `arith.constant` op to `mod_arith`:
```
arith.constant 17 : i32
-->
mod_arith.constant 17 : !mod_arith.mod_arith<234 : i32>
```
- comment on getValue nightmare
- mod_arith.mod_arith -> mod_arith.int
j2kun
force-pushed
the
modarith-constant
branch
from
eff831c
to
10721ef
Compare
j2kun
added
the
pull_ready
|
Fixes applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This custom-parsed op and attribute make it relatively easy to systematically change an
arith.constantop tomod_arith:Cherry-picked from #1096 so it works well with the polynomial coefficient type migration