Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python tests suite fails on windows #789

Open
reyammer opened this issue Nov 4, 2024 · 0 comments
Open

python tests suite fails on windows #789

reyammer opened this issue Nov 4, 2024 · 0 comments
Labels
help wanted Extra attention is needed python Pull requests that update Python package testing This issue is about improving testing

Comments

@reyammer
Copy link
Collaborator

reyammer commented Nov 4, 2024

The tests suite at https://github.com/google/magika/blob/main/.github/workflows/python-test-suite.yml somehow fails when running it on windows.

Some of the failures are about mypy (rightfully) complaining about the signal module, but even when commenting that out, other issues pop out when running the tests. These include some misdetection-related checks, which is very weird as nothing should change depending on the operating system.
@reyammer reyammer added python Pull requests that update Python package testing This issue is about improving testing help wanted Extra attention is needed labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed python Pull requests that update Python package testing This issue is about improving testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reyammer