Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS, 9.4.0+) It is no more possible to build plugin from sources (missing preload features headers) #3718

Open
Remstam opened this issue Jan 13, 2025 · 4 comments
Assignees
Labels
P1 Priority issue. Plugin Issue with the Unity plugin.

Comments

@Remstam
Copy link

Remstam commented Jan 13, 2025

[REQUIRED] Step 1: Describe your environment

  • Unity version: 2021.3.42f1 (does not really matter, can be any of the latest stable)
  • Google Mobile Ads Unity plugin version: 9.4.0 and later
  • Plugin installation method: building from sources
  • Platform: iOS
  • Platform OS version: iOS 12 and later
  • Any specific devices issue occurs on: - (not device related issue)
  • Mediation ad networks used, and their versions: no mediation used

[REQUIRED] Step 2: Describe the problem

Not that long ago there was an issue (3181) where UMP was requested as a completely separated package from AdMob. As far as this feature is still somewhere in the plans, we still can make this separation ourselves using sources provided with every release (for example, here is the link for the latest 9.5.0 release sources), despite it requires some nontrivial steps to make it work.

It looks like for iOS things has been changed since 9.4.0: preloaded ads feature was added, but some headers is nowhere to be found:

Those headers named with -preview suffix are also not presented in the latest iOS SDK 11.13.0.

If I try to install plugin via .unitypackage, it builds fine, so the headers are there inside unity-plugin-library.a I guess.

So the question is - is it possible to add those missing headers so we can build from the sources again? Just some commit will be fine to grab, it's not really necessary to wait longer for the next official release.

(It is still possible to build separate packages on Android platform with 9.4.0 and 9.5.0 sources)

Steps to reproduce:

Unfortunately, steps are too complex to reproduce, but I think it's not needed yet at this point of discussion.

Relevant Code:

// No code needed for this issue
@NVentimiglia
Copy link
Member

Thanks for raising this issue,

Give me some time to look into this issue. In the mean time, is it possible to use the unityPackage ?

@NVentimiglia NVentimiglia self-assigned this Jan 15, 2025
@NVentimiglia NVentimiglia added Plugin Issue with the Unity plugin. P1 Priority issue. labels Jan 15, 2025
@Remstam
Copy link
Author

Remstam commented Jan 16, 2025

is it possible to use the unityPackage?

Yes, it is. The only thing is when another ads mediation is used (e.g. ironSource) AdMob related only scripts may be not fully stripped from the build and thus staying inside unused.

So my current approach is to use 9.3.0 from sources, but bump up AdMob's iOS and Android SDK's to the versions from the latest 9.5.0 release - just to be in flow with mediation adapters.

@RomainBitard
Copy link

@Remstam is it working from unity package or should I not uprade to 9.5.0 ?

@Remstam
Copy link
Author

Remstam commented Jan 27, 2025

@Remstam is it working from unity package or should I not uprade to 9.5.0 ?

@RomainBitard It is working from unity package (it builds without errors at least)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority issue. Plugin Issue with the Unity plugin.
Projects
None yet
Development

No branches or pull requests

3 participants