GoogleAuth type should be generic GoogleAuth<T extends AuthClient>

[edosrecki]

I am trying to instantiate a Sqladmin class by passing a custom GoogleAuth object, which was in turn instantiated by passing a custom AuthClient object.

However, I get a TypeScript error shown below, which is due to the fact that Sqladmin class expects auth: GoogleAuth, which is defaulted to GoogleAuth<JSONClient>, where JSONClient = JWT | UserRefreshClient | BaseExternalAccountClient | ExternalAccountAuthorizedUserClient | Impersonated;

I believe that Sqladmin class should be parameterized with T extends AuthClient, and then it should accept GoogleAuth<T> in the auth property.

Code

import {AuthClient, GoogleAuth} from 'google-auth-library';
import {sqladmin_v1beta4} from '@googleapis/sqladmin';
const {Sqladmin} = sqladmin_v1beta4;

function buildSqlAdmin (authClient: AuthClient) {
  const auth = new GoogleAuth<AuthClient>({
    auth: authClient,
    scopes: ['https://www.googleapis.com/auth/sqlservice.admin'],
  });

  return new Sqladmin({
    auth
  });
}

TypeScript Error

Type Definitions

Sqladmin:

google-api-nodejs-client/src/apis/sqladmin/v1beta4.ts

Line 54 in 2611705

| GoogleAuth;

GoogleAuth:

https://github.com/googleapis/google-auth-library-nodejs/blob/7030314c55c369acbda1873f649579b395ad07c8/src/auth/googleauth.ts#L85

[danielbankhead]

Related:

• feat(SQLAdminFetcher): Support base AuthClient for auth and loginAuth GoogleCloudPlatform/cloud-sql-nodejs-connector#238

The root of this request will be resolved here (for all googleapis libraries):

• feat!: Normalize GoogleAuth<T> to AuthClient google-auth-library-nodejs#1677