Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove RefreshOptions type in OAuth2Client #1675

Open
danielbankhead opened this issue Oct 12, 2023 · 4 comments
Open

refactor!: Remove RefreshOptions type in OAuth2Client #1675

danielbankhead opened this issue Oct 12, 2023 · 4 comments
Assignees
@milinddethe15
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Contributor

As of #1663 no clients use this now:
@danielbankhead danielbankhead added type: cleanup An internal cleanup or hygiene concern. semver: major Hint for users that this is an API breaking change. good first issue This issue is a good place to started contributing to this repository. Breaking Change priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version labels Oct 12, 2023
@danielbankhead danielbankhead changed the title refactor!: Remove RefreshOptions type in OAuth2Client refactor!: Remove RefreshOptions type in OAuth2Client Oct 12, 2023
@milinddethe15
Copy link

Hi @danielbankhead, I would like to work on this. If I understood the issue, I just have to remove extends RefreshOptions from

export interface OAuth2ClientOptions extends RefreshOptions {
  clientId?: string;
  clientSecret?: string;
  redirectUri?: string;
  credentials?: Credentials;
}

@danielbankhead
Copy link
Contributor Author

Hey @milinddethe15, good question - after #1663 has been merged the RefreshOptions interface itself can be removed.

@danielbankhead danielbankhead removed their assignment Oct 13, 2023
@milinddethe15
Copy link

Hi, I want to work on this issue. Assign me.

@danielbankhead
Copy link
Contributor Author

danielbankhead commented Oct 13, 2023 •
edited
Loading

@milinddethe15 done! Take your time as this refactor is a breaking change and we won’t release another major for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milinddethe15 milinddethe15

Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielbankhead @milinddethe15