-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of OAuth2Client.verifyIdToken in example #243
Fix usage of OAuth2Client.verifyIdToken in example #243
Conversation
Thank you for catching this :) Could you also add the audience in the new options? const ticket = await oAuth2Client.verifyIdToken({
idToken: oAuth2Client.credentials.id_token,
audience: keys.web.client_id
}); |
eff5676
to
48ef511
Compare
@JustinBeckwith I added a part |
@JustinBeckwith I'm also wondering if |
The audience should be set to |
48ef511
to
d217b20
Compare
@JustinBeckwith Oh, alright, I've updated the PR. The I mean, when I read the test, I don't get the impression that the audience should correspond to the client ID so it's confusing :) |
omg this is why it doesn't work... T-T So, this doc need some update too |
examples/verifyIdToken.js uses the old signature for
OAuth2Client.verifyIdToken
, this PR upgrades it to the new API.