fix(spanner): json null handling #10660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a string comparison the compiler can significantly optimize the check.
The caller can change the result from these calls and this may cause weird bugs down the line. Instead allocate a new slice.
egonelbre
changed the title
|
Hello @egonelbre Can you please share what was the corner case with regards to mutation? |
|
@rahul2393 I added a test to show the main idea. Basically, when a user changes |
rahul2393
added
the
kokoro:force-run
rahul2393
approved these changes
Aug 19, 2024
kokoro-team
removed
the
kokoro:force-run
|
@rahul2393 in case it's not clear, I'm not able to merge any of my PR-s myself. |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance and fixes a potential corner case with regards to mutations.