Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/postprocessor): only regen snippets for changed modules #7300

Merged
merged 8 commits into from
Feb 8, 2023

Conversation

adrianajg
Copy link
Contributor

This change identifies the changed modules in the PR using the commit URLs in the open OwlBot PR description. The scopes are used to limit snippet regeneration to only those modules.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 25, 2023
@adrianajg adrianajg marked this pull request as ready for review January 25, 2023 22:34
@adrianajg adrianajg requested a review from a team as a code owner January 25, 2023 22:34
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@adrianajg adrianajg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed requested changes and have a question if you don't mind taking a look. Thank you!

internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Show resolved Hide resolved
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Show resolved Hide resolved
internal/postprocessor/main.go Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@adrianajg adrianajg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed changes. Let me know if you see anything else. Thanks!

internal/postprocessor/main.go Show resolved Hide resolved
internal/postprocessor/main.go Show resolved Hide resolved
internal/postprocessor/main.go Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2023
@codyoss codyoss merged commit 220f8a5 into googleapis:main Feb 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2023
@codyoss codyoss deleted the limit-snippets-regen branch February 8, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants