fix(spanner): ensure defers run at the right time in tests #9759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defers are executed at the end of the func, not at the end of the loop. This adds func closures to ensure that they execute within the single test.
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@rahul2393 for review |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
approved these changes
Aug 14, 2024
|
@rahul2393 can this be merged? |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defers are executed at the end of the func, not at the end of the loop. This adds func closures to ensure that they execute within the single test.
I wasn't sure whether it would've been preferrable to use subtests instead of func closures. I can adjust the fix as needed.
Fixes #10323