Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: support signed URL on GAE and GCE #2142

Closed
neozwu opened this issue Jun 12, 2017 · 2 comments
Closed

Storage: support signed URL on GAE and GCE #2142

neozwu opened this issue Jun 12, 2017 · 2 comments
Assignees
@neozwu
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@neozwu
Copy link
Contributor

neozwu commented Jun 12, 2017

Today signed url requires a service account with a signer. GAE and GCE use their built-in service account, which cannot sign blob. Our current impl only retrieves signer from service account. Therefore, it is not working on GAE and GCE. GAE has appIdentity.signForApp API that can be used to sign blob. It seems there's ongoing work to support GCE to sign blob. We should make GAE ( and GCE once it's ready) blob signing available in client lib as well.
@neozwu neozwu self-assigned this Jun 12, 2017
@neozwu neozwu added the api: storage Issues related to the Cloud Storage API. label Jun 12, 2017
@garrettjonesgoogle garrettjonesgoogle added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 17, 2017
@garrettjonesgoogle
Copy link
Member

@neozwu there are two tasks in here: 1) GAE, 2) GCE. Could you split this apart?

@neozwu
Copy link
Contributor Author

neozwu commented Nov 15, 2017

GAE & GCE now both use metadata server. Close this issue since supporting signing URL is tracked in #2629

@neozwu neozwu closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neozwu neozwu

Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garrettjonesgoogle @neozwu