cloudtrace: not working anymore with rails >= v7.1.4

[koljaa]

https://github.com/googleapis/google-cloud-ruby/blob/main/google-cloud-trace/lib/google/cloud/trace/notifications.rb#L121 This patch is not valid anymore for Rails version >= v7.1.4

See https://github.com/rails/rails/blob/v7.1.4/activesupport/lib/active_support/notifications/instrumenter.rb#L123

In our case the traces were arriving the service but with broken start times. Therefore the traces were not displayed in the Graph.

Environment details

• Ruby version: 3.3.5
• Gem name and version: google-cloud-trace 0.44.0
• Rails version: >= v7.1.4

Steps to reproduce

Update to Rails >= v7.1.4

Code example

# example

Full backtrace

Traces are arriving the service but with broken start times so that the traces are not displayed in the Graph. However some traces can be found by directly searching with the trace id. That way i could see the broken start times.

[dazuma]

The google-cloud-trace gem's instrumentation features are not currently actively maintained. I recommend using OpenTelemetry instead for trace instrumentation.

[koljaa]

@dazuma thanks for your answer. So basically i would need to implement the complete rails instrumentation part? I think the fix is really easy by just adding another condition to check for rails version >=7.1.4. Any chance to get this implemented or can i provide a PR to add it?

[koljaa]

        ##
        # @private
        #
        # active support event's time is:
        #
        # - rails <  7: time
        # - rails >= 7 && < 7.1.4 : timestamp in milliseconds
        # - rails >= 7.1.4: time
        def self.normalize_time time_or_float
          return time_or_float if Rails::VERSION::MAJOR < 7 || Gem::Version.new(Rails.version) >= Gem::Version.new('7.1.4')

          Time.at time_or_float / 1000
        end
      end

https://github.com/googleapis/google-cloud-ruby/blob/main/google-cloud-trace/lib/google/cloud/trace/notifications.rb#L121

That way its working again.