Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support event type pre-release versions #160

Merged
merged 2 commits into from
Mar 30, 2023
Merged

fix: support event type pre-release versions #160

merged 2 commits into from
Mar 30, 2023

Conversation

grayside
Copy link
Contributor

Fixes #159

From the generator output on my local machine:

- audit: cloud/audit/v1/data.proto => cloud/auditdata
- dataflow: cloud/dataflow/v1beta3/data.proto => cloud/dataflowdatav1beta3
- functions: cloud/functions/v2/data.proto => cloud/functionsdatav2

New file added for DataFlow event type:

cloud/dataflowdatav1beta3/

@grayside grayside requested a review from a team as a code owner March 28, 2023 20:03
@grayside grayside self-assigned this Mar 28, 2023
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-go API. label Mar 28, 2023
iennae
iennae approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We expect GA libraries to follow the format of v{NUM}

Based on new information we expect pre-release libraries to follow the format of

v{NUM}{WORD}{NUM}

so in this example v1beta3 matches

@grayside grayside merged commit 58aab52 into main Mar 30, 2023
@grayside grayside deleted the fix-prerelease-versions branch March 30, 2023 18:22
@release-please release-please bot mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

@jskeet jskeet jskeet approved these changes

Assignees

@grayside grayside

Labels
api: eventarc Issues related to the googleapis/google-cloudevents-go API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generator: Version string munging cannot handle dataflow's v1beta3
3 participants
@grayside @jskeet @iennae