fix: add user-agent on requests #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
frankyn
requested changes
Jan 25, 2022
added 2 commits
January 25, 2022 12:27
unforced
changed the title
added 2 commits
January 25, 2022 14:18
andrewsg
requested changes
Jan 25, 2022
frankyn
approved these changes
Jan 28, 2022
tswast
reviewed
Feb 8, 2022
| @@ -45,6 +46,13 @@ def do_nothing(): | |||
| """Simple default callback.""" | |||
|
|
|||
|
|
|||
| def _base_headers(headers): | |||
| version = pkg_resources.get_distribution("google-resumable-media").version | |||
| headers["User-Agent"] = "gcloud-python/{}-resumable-media".format(version) | |||
There was a problem hiding this comment.
This should not blindly override headers. At most it should append this to the end of an existing header.
I recommend using setdefault() or similar logic next time.
unforced
pushed a commit
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Still need to change a number of tests, especially on uploads.