Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksums are validated for partial responses #362

Closed
simonbohnen opened this issue Oct 4, 2022 · 0 comments · Fixed by #361
Closed

Checksums are validated for partial responses #362

simonbohnen opened this issue Oct 4, 2022 · 0 comments · Fixed by #361
Assignees
@cojenco
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@simonbohnen
Copy link
Contributor

Environment details

  • OS type and version: macOS 12.5.1
  • Python version: 3.10.7
  • pip version: 22.2.2
  • google-resumable-media version: 2.4.0

Steps to reproduce

This is hard to reproduce as the live GCS doesn't seem to send checksums for partial responses.
This fake-gcs-server however includes checksums with partial responses (HTTP status 206), which seems to be allowed according to the box here.

I would suggest skipping validation when we receive a partial response.
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label Oct 4, 2022
@simonbohnen simonbohnen mentioned this issue Oct 4, 2022
Merged
4 tasks
@cojenco cojenco self-assigned this Oct 6, 2022
@cojenco cojenco added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Oct 7, 2022
@cojenco cojenco added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed status: investigating The issue is under investigation, which is determined to be non-trivial. labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cojenco cojenco

Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid validating checksums for partial responses simonbohnen/google-resumable-media-python
2 participants
@simonbohnen @cojenco