Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow integration tests should be improved to reduce build time #3247

Open
olavloite opened this issue Aug 7, 2024 · 0 comments
Open

Slow integration tests should be improved to reduce build time #3247

olavloite opened this issue Aug 7, 2024 · 0 comments
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: process A process-related concern. May include testing, release, or the like.

Comments

@olavloite
Copy link
Collaborator

olavloite commented Aug 7, 2024 •
edited
Loading

The slowest integration tests at the moment are:

[INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 864.9 s -- in com.google.cloud.spanner.connection.it.ITDmlReturningTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 358.9 s -- in com.google.cloud.spanner.it.ITAutogeneratedAdminClientTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 294.8 s -- in com.google.cloud.spanner.it.ITDatabaseRolePermissionTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 292.6 s -- in com.google.cloud.spanner.it.ITDatabaseAdminTest
[INFO] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 462.7 s -- in com.google.cloud.spanner.connection.it.ITTransactionRetryTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 323.4 s -- in com.google.cloud.spanner.it.ITClosedSessionTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 246.4 s -- in com.google.cloud.spanner.it.ITBatchDmlTest
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 234.8 s -- in com.google.cloud.spanner.it.ITCommitTimestampTest

The current overall build time for the normal integration tests are around 25 minutes.
@olavloite olavloite added the type: process A process-related concern. May include testing, release, or the like. label Aug 7, 2024
@olavloite olavloite self-assigned this Aug 7, 2024
olavloite added a commit that referenced this issue Aug 7, 2024
@olavloite
test: speed up ITDmlReturningTest
07560bc 
The initialization code for ITDmlReturningTest was borked and initialized
the database over and over again for each test method. This pushes Spanner
into throttling the DDL requests, which again makes both this and other
integration tests slow.

Updates #3247
@olavloite olavloite mentioned this issue Aug 7, 2024
Merged
rahul2393 pushed a commit that referenced this issue Aug 7, 2024
@olavloite
test: speed up ITDmlReturningTest (#3248)
52f8684 
The initialization code for ITDmlReturningTest was borked and initialized
the database over and over again for each test method. This pushes Spanner
into throttling the DDL requests, which again makes both this and other
integration tests slow.

Updates #3247
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olavloite