From b61a9764a9d953d2b214edb2b543b8df42fbfa06 Mon Sep 17 00:00:00 2001 From: BenWhitehead Date: Thu, 27 Jul 2023 15:04:24 -0400 Subject: [PATCH] fix(grpc): return error if credentials are detected to be null (#2142) --- .../main/java/com/google/cloud/storage/GrpcStorageOptions.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java index 8bb3115c52..a6aa331350 100644 --- a/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java +++ b/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java @@ -48,6 +48,7 @@ import com.google.cloud.storage.UnifiedOpts.UserProject; import com.google.cloud.storage.spi.StorageRpcFactory; import com.google.common.base.MoreObjects; +import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableSet; import com.google.storage.v2.ReadObjectRequest; @@ -169,6 +170,7 @@ private Tuple> resolveSettingsAndOpts() throw Opts defaultOpts = Opts.empty(); CredentialsProvider credentialsProvider; + Preconditions.checkState(credentials != null, "Unable to resolve credentials"); if (credentials instanceof NoCredentials) { credentialsProvider = NoCredentialsProvider.create(); } else {