Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make GrpcBlobWriteChannel open upon construction #2022

Merged
merged 1 commit into from
May 17, 2023

Conversation

BenWhitehead
Copy link
Collaborator

Add new integration tests for both json and grpc to verify openness

@BenWhitehead BenWhitehead requested a review from a team as a code owner May 15, 2023 21:46
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 15, 2023
@BenWhitehead BenWhitehead added owlbot:ignore instruct owl-bot to ignore a PR and removed size: m Pull request size is medium. labels May 15, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label May 15, 2023
Add new integration tests for both json and grpc to verify openness
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 17, 2023
@BenWhitehead BenWhitehead added the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6549736 into main May 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the writeChannel-open branch May 17, 2023 21:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants