Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new Storage#moveBlob method to atomically rename an object #2882

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

@BenWhitehead BenWhitehead requested a review from a team as a code owner January 14, 2025 21:08
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Jan 14, 2025
@BenWhitehead BenWhitehead requested a review from a team as a code owner January 14, 2025 21:30
return new Builder(source, target, sourceOptions, targetOptions);
}

public static Builder newBuilder() {
Copy link
Contributor

@JesseLovelace JesseLovelace Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we maybe want to add something like MoveBlobRequest.of(BlobIdSource, BlobId target) for convenience?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but I sort of like having the builder methods that nudge people to at least think about preconditions. A move is only retryable if the target has a precondition set on it.

@BenWhitehead BenWhitehead merged commit c49fd08 into main Jan 22, 2025
21 checks passed
@BenWhitehead BenWhitehead deleted the feat/move-blob branch January 22, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants