-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support string-encoded json #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
Issues related to the googleapis/python-logging API.
label
Jun 24, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 24, 2021
daniel-sanche
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 26, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 26, 2021
daniel-sanche
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 26, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 26, 2021
simonz130
approved these changes
Jul 27, 2021
daniel-sanche
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 27, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 27, 2021
daniel-sanche
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 27, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 27, 2021
daniel-sanche
added a commit
that referenced
this pull request
Jan 27, 2022
daniel-sanche
added a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/python-logging API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently merged a PR into the v3.0.0 staging branch adding support for logging dicts as jsonPayload logs in our custom handlers:
While this can be useful in basic logging set-ups, the Python logging API expects string-like msg inputs, so this can't always be relied on to work properly in more complex logging environments.
With this PR, the handlers will also attempt to parse a dictionary out of the final log string before sending it on Cloud Logging, so string-encoded dictionaries will work as expected:
This also allows you to set a formatter object with logging attributes once, and then continue to log strings as normal. Each log will now show up in jsonPayload format in CloudLogging
You can also specify in custom fields using the
extra
argument:Fixes #331