Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Autogenerated Samples #582

Closed
daniel-sanche opened this issue Jul 7, 2022 · 2 comments · Fixed by #804
Closed

Fix Autogenerated Samples #582

daniel-sanche opened this issue Jul 7, 2022 · 2 comments · Fixed by #804
Assignees
@gkevinzheng
Labels
api: logging Issues related to the googleapis/python-logging API. documentation Improvements or additions to documentation priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@daniel-sanche
Copy link
Contributor

The log tailing samples (synchronous, asynchronous) have an issue where the object paths are out of date (logging_v2.LoggingServiceV2Client() should be logging_v2.services.logging_service_v2.LoggingServiceV2Client(), etc)

We should check the autogenerated samples to make sure they are all tested
@daniel-sanche daniel-sanche added documentation Improvements or additions to documentation priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jul 7, 2022
@daniel-sanche daniel-sanche self-assigned this Jul 7, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Jul 7, 2022
@losalex losalex added the type: docs Improvement to the documentation for an API. label Jul 16, 2022
@Ripeey
Copy link

Ripeey commented Sep 22, 2022

Also logging_v2.types.TailLogEntriesRequest, but it still gives me no response is there working example of tailing logs?

@dlobsinger
Copy link

Is there any update on a working sample of using tail_log_entries?

@gkevinzheng gkevinzheng pinned this issue Oct 19, 2023
@gkevinzheng gkevinzheng unpinned this issue Oct 19, 2023
@gkevinzheng gkevinzheng self-assigned this Oct 20, 2023
@daniel-sanche daniel-sanche removed their assignment Oct 20, 2023
This was referenced Oct 26, 2023
Merged
Open
@gkevinzheng gkevinzheng mentioned this issue Nov 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkevinzheng gkevinzheng

Labels
api: logging Issues related to the googleapis/python-logging API. documentation Improvements or additions to documentation priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fixed object paths in autogenerated code in owlbot.py googleapis/python-logging
5 participants
@daniel-sanche @dlobsinger @Ripeey @losalex @gkevinzheng