-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include context on batch log errors #650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: logging
Issues related to the googleapis/python-logging API.
labels
Oct 12, 2022
losalex
reviewed
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets some comments
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Oct 13, 2022
daniel-sanche
changed the title
[DRAFT] feat: include context on batch log errors
feat: include context on batch log errors
Oct 17, 2022
losalex
approved these changes
Oct 17, 2022
daniel-sanche
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 17, 2022
yoshi-kokoro
removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/python-logging API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, a log may fail as part of a larger batch of logs (eg, due to payload size). These exceptions can be hard to track down, because batches happen asynchronously on a background thread
This PR attempts to help resolve the issue by adding a truncated copy of the failing log to the batch log exception message
Fixes: #53