-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dual region bucket support and sample #748
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit - we'll want to update references from 'dual region' to 'dual-region'
Update - Python samples projects have been added to the allowlist (internal cl/438869140). Awaiting for deployment in the next 2 weeks. |
@danielbankhead thanks for the review! Do you mean updating the docstrings in client.py? |
Yep, correct |
Updated the docstrings and the docs link as discussed in java thread. |
Note(04.06.2022): Dual-region storage is currently a Pre-GA feature https://cloud.google.com/storage/docs/dual-regions |
@@ -875,8 +875,9 @@ def create_bucket( | |||
made via created bucket. | |||
location (str): | |||
(Optional) The location of the bucket. If not passed, | |||
the default location, US, will be used. See | |||
https://cloud.google.com/storage/docs/bucket-locations | |||
the default location, US, will be used. If specifying a dual-region, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest the following:
(Optional) The location of the bucket. If not passed, the default location, 'US', will be used. If specifying a dual-region location, the regions can be specified by joining them with a plus sign, for example 'US-CENTRAL1+US-WEST1'. See:
https://cloud.google.com/storage/docs/locations
Add dual region bucket support and sample
client.create_bucket()
accepts a dual-regionlocation
as a string with 2 regions concatenated with a '+' (e.g."US-EAST1+US-WEST1"
)Fixes #739 🦕