Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hermetic build integration test to golden test #3343

Open
JoeWang1127 opened this issue Nov 7, 2024 · 0 comments
Open

Change hermetic build integration test to golden test #3343

JoeWang1127 opened this issue Nov 7, 2024 · 0 comments
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

Currently, the integration test (hermetic_build/library_generation/tests/integration_tests.py) uses a branch (chore/test-hermetic-build) in google-cloud-java to verify the generation result.

This setting makes it not obvious on how to change the golden files.

We should copy the files from google-cloud-java as golden files to verify the integration test.
@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. hermetic-build labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoeWang1127