Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an empty versions.txt if it doesn't exist in repository-path #3389

Open
JoeWang1127 opened this issue Nov 20, 2024 · 0 comments
Open
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

In the hermetic library generation process, we require a versions.txt file exists in repository-path; otherwise raise FileNotFoundError in

raise FileNotFoundError(f"{versions_file} is not found.")

We didn't check the content of this file and the post processor can add versions for new client, therefore we should create an empty file if not exist, rather than raise an exception.

The generated library will have a 0.0.1-SNAPSHOT version.

@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. hermetic-build labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant