Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

fix: read data from bigquery table #1116

Merged
merged 19 commits into from
Aug 4, 2022
Merged

fix: read data from bigquery table #1116

merged 19 commits into from
Aug 4, 2022

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Aug 3, 2022

We need the table name

@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 3, 2022
@tmatsuo tmatsuo requested a review from a team as a code owner August 3, 2022 23:54
@tmatsuo tmatsuo requested a review from a team August 3, 2022 23:54
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 3, 2022
@tmatsuo tmatsuo force-pushed the read-from-bigquery branch from 3b03a0e to da7181b Compare August 3, 2022 23:55
src/issue.ts Outdated Show resolved Hide resolved
Takashi Matsuo added 5 commits August 3, 2022 18:08
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
also just use ApiIssue interface
@tmatsuo tmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 4, 2022
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 4, 2022

Ok, now it's a decent chance that the code will work. I'd like to test it with test spreadsheet.

@tmatsuo tmatsuo merged commit 4c8cc10 into main Aug 4, 2022
@tmatsuo tmatsuo deleted the read-from-bigquery branch August 4, 2022 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants