-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot bundle this lib #260
Comments
Looks like this is blocked on moving to Node 14. As per this comment, that was scheduled for months ago. Any updates on when this is planned for? |
getting close! #312 |
Just wanted to drop a quick note. If the bundling issue with webpack/esbuild is being caused by |
Would you be able to elaborate on that? |
Is there any plan to move to a different Fetch library or otherwise fix this? Alternatively, backport the fix that node-fetch implemented in 3.x to 2.x. It is a poor state of affairs that I can't use TypeScript and the official GCP Node SDK to upload from GCP Functions to GCP Storage because of a 2 year old bug in Google's own request library. |
Hey guys,
when I bundle this lib (e.g. with esbuild or webpack) I am getting the following error:
TypeError: Expected signal to be an instanceof AbortSignal
This is caused by node-fetch 2.x and is solved with versions 3.x, see here:
node-fetch/node-fetch#667
Do you plan to update node-fetch in the near future? I would need that fix for
@google-cloud/[email protected]
.Thanks in advance
The text was updated successfully, but these errors were encountered: