Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for NO_PROXY #272

Merged
merged 3 commits into from
Mar 31, 2022
Merged

feat: Add support for NO_PROXY #272

merged 3 commits into from
Mar 31, 2022

Conversation

danielbankhead
Copy link
Contributor

Adds support for the NO_PROXY environment variable.

@danielbankhead danielbankhead requested a review from a team as a code owner March 31, 2022 22:38
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

bcoe
bcoe approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit.

test/agents.ts Outdated Show resolved Hide resolved
@danielbankhead danielbankhead merged commit b02b6e5 into main Mar 31, 2022
@danielbankhead danielbankhead deleted the no-proxy-support branch March 31, 2022 23:16
@release-please release-please bot mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbankhead @bcoe @d-goog