-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(runner): fix missing timing properties in the browser #9072
Conversation
Interestingly, running LH in DevTools seems to defeat marky's environment sniffing and so it uses the fallback objects and the entries are ok. The extension is like lr here and only has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bam nice work! with 1.5 quarters to spare too 😎
can we add a hexa test to LR |
Summary
PerformanceEntries in Lightrider (and the extension) had no names and no entryTypes. This manifested as a 0
timing.total
in the API as well.@brendankenny found that browser PerformanceEntry objects do not spread, but in Node they do b/c of the marky lib. So, simple fix to explicitly call out the
name
andentryType
fields when parsing the entries. This will also populate the missinglh:runner:run
entry to fill intiming.total
.Related Issues/PRs
fixes: #8638