core(audits): point PWA audit description links to web.dev #9539
Conversation
mfriesenhahn
requested review from
brendankenny,
exterkamp,
patrickhulce and
paulirish
as code owners
There was a problem hiding this comment.
LGTM other than the redirects one
Do we want to add one for the PWA overall "Learn more" link?
(Note for other reviewers that the HTTPS one is covered by the best practices PR #9538 )
| @@ -17,7 +17,7 @@ class RedirectsHTTP extends Audit { | |||
| title: 'Redirects HTTP traffic to HTTPS', | |||
| failureTitle: 'Does not redirect HTTP traffic to HTTPS', | |||
| description: 'If you\'ve already set up HTTPS, make sure that you redirect all HTTP ' + | |||
| 'traffic to HTTPS. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).', | |||
| 'traffic to HTTPS. [Learn more](https://web.dev/redirects-http).', | |||
There was a problem hiding this comment.
this doc seems to give the opposite advice, we want them to redirect their http traffic to https and the doc is mostly talking about avoiding redirects
|
Oh and I don't know if we plan to move the PWA checklist over too or not |
|
I'm wondering @paulirish if |
shouldn't it be ok and this just needs an |
|
jk I did it :) |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
brendankenny
changed the title
I discussed with @exterkamp, and we were thinking it'd make sense to leave these as-is for now until we get the relevant info migrated to web.dev. Afterward, we can point those links to the landing page for each collection, if that SGTY. |
|
@patrickhulce, I've copied your content comments to web.dev issue 1343 for tracking. |
Summary
Points "Learn more" links in PWA audits to relevant web.dev guides.
Note
web.dev currently doesn't have a post for the Provides a valid apple-touch-icon audit. We'll try to draft one quickly.