Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(proto): don't filter channel from configSettings #9554

Merged
merged 1 commit into from
Aug 15, 2019
Merged

clients(proto): don't filter channel from configSettings #9554

merged 1 commit into from
Aug 15, 2019

Conversation

exterkamp
Copy link
Member

Summary
channel never made the roundtrip! And 'lr' got lost in the process.

patrickhulce
patrickhulce approved these changes Aug 14, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't suppose there's anything else missing while we're in here? everything else looks OK to me

@exterkamp
Copy link
Member Author

I don't suppose there's anything else missing while we're in here? everything else looks OK to me

I'm doing integration testing now with a fine toothed comb. So...I don't know yet! But we'll see!

@brendankenny brendankenny changed the title proto: add channel to preprocessor configSettings whitelist clients(proto): don't filter channel from configSettings Aug 15, 2019
brendankenny
brendankenny approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

I'm doing integration testing now with a fine toothed comb. So...I don't know yet! But we'll see!

just to be clear, the above makes it sound like you'd open up another PR if you find more things, right?

@brendankenny brendankenny merged commit f552253 into master Aug 15, 2019
@brendankenny brendankenny deleted the fix-channel branch August 15, 2019 23:03
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@exterkamp @paulirish
clients(proto): don't filter channel from configSettings (#9554)
ec68de7
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exterkamp @brendankenny @patrickhulce @googlebot