report: don't use unnessary monospace #9626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Aug 29, 2019
patrickhulce
approved these changes
Aug 29, 2019
| @@ -78,7 +78,7 @@ class ErrorLogs extends Audit { | |||
| /** @type {LH.Audit.Details.Table['headings']} */ | |||
| const headings = [ | |||
| {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)}, | |||
| {key: 'description', itemType: 'code', text: str_(UIStrings.columnDesc)}, | |||
| {key: 'description', itemType: 'text', text: str_(UIStrings.columnDesc)}, | |||
There was a problem hiding this comment.
I think I'd prefer to keep this one as code since in my experience these are less wall of text than deprecation explanations, but I don't feel terribly strongly.
There was a problem hiding this comment.
yeah, I probably agree with this (and monospace matches how it's displayed in the devtools console), but without auto code markdown for the symbols in each of these, display won't be ideal, mono or not
brendankenny
approved these changes
Aug 31, 2019
| @@ -78,7 +78,7 @@ class ErrorLogs extends Audit { | |||
| /** @type {LH.Audit.Details.Table['headings']} */ | |||
| const headings = [ | |||
| {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)}, | |||
| {key: 'description', itemType: 'code', text: str_(UIStrings.columnDesc)}, | |||
| {key: 'description', itemType: 'text', text: str_(UIStrings.columnDesc)}, | |||
There was a problem hiding this comment.
yeah, I probably agree with this (and monospace matches how it's displayed in the devtools console), but without auto code markdown for the symbols in each of these, display won't be ideal, mono or not
|
|
paulirish
added a commit
that referenced
this pull request
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we shouldn't render sentences or paragraphs in monospace. not very readable.
before
after
