clients(devtools): expose registerLocaleData to worker #9645
Conversation
There was a problem hiding this comment.
What do you think about removing registerLocaleData from the lighthouse module and calling it on i18n in here?
If the intention is for registerLocaleData to only ever be used by devtools and it has to be exposed on devtools-entry regardless of whether it's on lighthouse (and my bundler solution doesn't work for you), then that would at least keep the singleton-stomping power limited to a well-behaved client.
great suggestion. i'll do that. |
| afterEach(() => { | ||
| // eslint-disable-next-line no-unused-vars | ||
| let replacedLocales = require('../../../lib/i18n/locales.js'); | ||
| replacedLocales = clonedLocales; |
There was a problem hiding this comment.
seems like this wouldn't restore it (just overwrite the local var)? It might have to restore all the individual props (or just the single test could do it for just the one locale)
There was a problem hiding this comment.
quite true. addressed in cd9f8fd
clients/devtools-entry.js
Outdated
| @@ -8,6 +8,7 @@ | |||
| const lighthouse = require('../lighthouse-core/index.js'); | |||
| const RawProtocol = require('../lighthouse-core/gather/connections/raw.js'); | |||
| const log = require('lighthouse-logger'); | |||
| const {registerLocaleData} = require('../lighthouse-core/lib/i18n/i18n.js'); | |||
There was a problem hiding this comment.
Would you like to export the lookupLocale with this function too?
| // @ts-ignore | ||
| self.registerLocaleData = registerLocaleData; | ||
| // @ts-ignore | ||
| self.lookupLocale = lookupLocale; |
No description provided.