tests(smokehouse): check runWarnings

[connorjclark]

Add lhr.runWarnings to the expectation checker. If not defined, the checker expects nothing to be there (like runtimeError).

[patrickhulce]

neat!

[brendankenny]

I'm not sure if it's super valuable to require that the expectations include the runWarnings since all these runWarnings are the same as the also-required runtimeError because we copy them over, (and we have tests that they're copied over and that gatherRunner LighthouseRunWarnings always become LHR runWarnings), but the implementation is small and these are low-churn enough that if you think this will be worthwhile, 👍 👍

[patrickhulce]

I'm not sure if it's super valuable to require that the expectations include the runWarnings since all these runWarnings are the same as the also-required runtimeError

To this end I'm about to propose something later today that would immediately eliminate this requirement FYI :) (just in the smokes PR here not globally for LH)

[brendankenny]

To this end I'm about to propose something later today that would immediately eliminate this requirement FYI :) (just in the smokes PR here not globally for LH)

🎶:ominous_music: 🎶

[connorjclark]

@brendankenny but this warnings array is not just runtime errors, some audits push warnings to this too (actually, just bootup-time, but IIRC there's some outstanding PR that adds another usage).

there can only be one runtime error, but many warnings, so I'm not sure the runtimeError catches all the same behavior.

[brendankenny]

@brendankenny but this warnings array is not just runtime errors, some audits push warnings to this too (actually, just bootup-time, but IIRC there's some outstanding PR that adds another usage).

I was just talking about requiring them, which requires the doubling up of all these messages, totally seems valuable to be able to assert them.