Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: remove some dead code #9800

Merged
merged 1 commit into from
Oct 8, 2019
Merged

report: remove some dead code #9800

merged 1 commit into from
Oct 8, 2019

Conversation

connorjclark
Copy link
Collaborator

  1. some fireworks css that is not used.
  2. old options menu used JS, new one does not.

patrickhulce
patrickhulce approved these changes Oct 7, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should get a score100 into our now[bot] deployments :)

lighthouse-core/report/html/templates.html
@@ -394,29 +394,6 @@
<!-- Lighthouse header -->
<template id="tmpl-lh-heading">
<style>
/*
TODO: Enable animating the clouds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@connorjclark connorjclark merged commit ceb6499 into master Oct 8, 2019
@connorjclark connorjclark deleted the report-rm-dead-code branch October 8, 2019 01:15
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@connorjclark @paulirish
report: remove some dead code (#9800)
ceb31b2
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @patrickhulce @googlebot