Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: rename Element to LHElement #9832

Merged
merged 3 commits into from
Oct 15, 2019
Merged

core: rename Element to LHElement #9832

merged 3 commits into from
Oct 15, 2019

Conversation

connorjclark
Copy link
Collaborator

While checking out the ts 3.7 beta, this typing mistake became apparent. We use the global Element type declaration (dom lib) where we really want our lib/element.js. Renaming to LHElement is a simple solution to this name clash.

image

the error was uncovered likely thanks to changes required for this bugfix: https://devblogs.microsoft.com/typescript/announcing-typescript-3-7-beta/ "Local and Imported Type Declarations Now Conflict"

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd say we could be more descriptive like DriverProxyElement or just ProxyElement something since I had to stare at this for a bit to remember why we have something called Element at all, but not required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants