Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider always setting explicit 'fill' even for default black paths as workaround for Firefox bug #472

Open
anthrotype opened this issue Aug 20, 2024 · 0 comments

Comments

@anthrotype
Copy link
Member

looks like Firefox renders implicitly black SVG paths with the current text color when they have no fill attribute, see:
googlefonts/noto-emoji#480

this is where nanoemoji omits setting the fill attribute when its value is 'black' which is the default according to SVG spec:

if paint.color.opaque() != Color.fromstring("black"):
el.attrib["fill"] = paint.color.opaque().to_string()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant