-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] GvhProjectSettings.xml changes/resets itself #524
Comments
This issue does not seem to follow the issue template. Make sure you provide all the required information. |
Hi @ManuelRauber, Could you provide the steps you've performed before facing this issue so that we can identify what's causing this behavior? |
I have the same issue. I've just installed External Dependency Manager with one of SDKs and these things start to happen. Looks like it happens after recompilation but not after each one. Also sometimes after exiting playmode. Unity editor version: 2021.3.3f1 |
We are facing same issue on |
Unfortunately, I can not answer this, because I simply use the Unity Editor. Sometimes that does not happen, I have no clear way to reproduce this behavior. Currently, I'm carefully looking whenever this change happens, but I've not found a clear way yet. |
Having the exact same issue. Reset happens every few minutes. Unity: 2021.3.4f1 |
Hi folks, Does disabling auto-resolution prevent this issue from happening? The Android Resolver automatically keeps track of the differentdependencies you have specified in your Unity project. The resolution process runs when the specified dependencies are not present in your project. |
For me issue is happening with auto-resolution turned off |
Same as above - it's turned off, but the issue is still occurring. Judging by all the reports seems to be mac specific. |
Hey @ManuelRauber. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Well, Google Bot, we can not add more information, because we don't have more information. I still have no way that I do to reproduce it. It just popped up after updating a Unity Package via Package Manager. To test, I reverted the changes in git and updated the unity package again. This time, the GvhProjectSettings.xml did not change. No clue, sorry. I'd love to help to investigate the issue, but since I can not cleary reproduce it, it's hard to track. |
Thanks for the update, folks. I'll bring this up with the team so that we can analyze this behavior. In the meantime, could you try our latest version of the resolver (1.2.172) to make sure the issue persists? |
I can report that we've been using this new version for a few days and so far no issues with the XML getting reset! The temporary file solution seems to solve the issue. Note that we have not tested changing any of the settings, so you should rely on others to verify that the XML file is being written correctly when it needs to be. |
An update after a few weeks - the issue has occurred again. However it happens way less often for sure, so at least it's quite an improvement! |
@MigrantP thanks for your feedback |
@paulinon Hi. When will this be fixed? This might be one of the most time consuming and annoying bugs ever. It is unfathomable that it's not been fixed yet. Can we pool a monetary bounty to Google to get it fixed? |
It's horrible. When will this be fixed? 🥲😭 |
Hi @paulinon. Any progress on this one? It's so incredibly risky to have the file auto reset it all the time by accidental commits, not to mention how infuriating it is to close the resolver dialog 50 times a day. This will drive people away from Firebase and other services Google is providing that are dependent on the resolver. |
@Tommigun1980 The "temporary file solution" that @AliAlbarrak posted on Oct 25 does work for us, have you tried it? |
Sorry for long delay since last update. I'm opening the pull request again as well. Again, your feedback is appreciated. |
@AliAlbarrak Salute! Feel so sad that the team ignored your work and no feedback at all. |
This issue is observed in 1.2.177 and 1.2.178. I am surprised that there's no official fix for an issue that started two years ago. |
I tried version 1.2.180 and so far everything is great!) |
@AliAlbarrak Thanks so much for the pull request. I tried your version but unfortunately there's still some issues. In my setup I have copied the .tgz file to the packages folder and selected "install from package" (so the manifest points to the local package path and the .tgz file is committed to source control). The issues are as follows:
If you have time to fix these issues, or if anyone else could build on the pull request that would be great, as I'm worried the pull request will otherwise be rejected as it doesn't fully solve the issue. Thanks so much again for your tremendous effort, I appreciate it a lot! |
@paulinon Please can't anyone from Google support us? The resolver has been quite broken for years and we are really scrambling to make this work. At this point any support for your software would be appreciated and would be in your interest as well, as the resolver makes sure software is released on Android platforms as well. Thank you. |
@Tommigun1980 Thanks for your report. |
Hi and thanks again for your effort with the patch. I don't have repro steps other than opening the project and the resolver pops up. Don't think I saw any difference vs the official version fwiw. I am using an Intel MacBook Pro (2019), macOS Ventura and Unity 2022.3.15. |
New fix attempt in #678 with an analysis of why this issue happens. |
Update: 1 month in at my org we're not seeing setting file corruption anymore on Windows and MacOS. |
Just a heads up, we tried @berniegp's fix recently and the binaries provided ended up breaking our iOS builds on Jenkins. We're currently on Unity 2022.3.22 and XCode 15.0.1 and for some reason using these updated binaries causes the resolver to never apply its postbuild processing and the Podfile is never generated which broke our Firebase dependency. Not entirely sure what the issue was since I see no obvious errors in the logs. It just seemed to ignore the settings file and never generate the Podfile. Reverting only the iOSResolver.dll to the non-patched version fixes the issue so we're hoping that doing only that will fix the settings file being reset in editor while allowing builds to complete. |
I've done a release with the fix, version 1.2.180. @jonsenson-uken I'm not sure what the issue you saw could be, I tried a couple different Unity versions to test, and it seemed good on my end. But if you are still having issues, please open a new issue ticket about it, along with anything that might help ping down a problem. |
Wow! Finally! |
@a-maurice We've updated to 1.2.180 and the Podfile issue doesn't appear to be present on that version. Thanks a lot for the release! |
That are great news! Thanks! |
Great NEWS! |
[REQUIRED] Please fill in the following fields:
[REQUIRED] Please describe the issue here:
Sometimes, not really reproducible, the file GvhProjectSettings.xml changes/resets itself. This is super annoying, because the file pops up in the git stage:
As well as this dialogs pops up all the time
And as you can see from the diff file above, the settings get reset, e.g. I've disabled both auto-resolution on build and in editor and it will reset back to true, because that's the default.
I currently can not reproduce it exactly, when it happens. Sometimes it does not happen all day, sometimes it happens multiple times day.
The text was updated successfully, but these errors were encountered: