feat: full gitlab support for brew and scoop #1084

mavogel · 2019-07-16T18:27:18Z

If applied, this commit will...

enabled the usage of gitlab for brew and scoop. This was still left open in #1038

Why is this change being made?

I would like to use gitlab as repo for my code for releasing to brew and scoop as well

Provide links to any relevant tickets, URLs or other resources

Steps

add brew for public and private gitlab
add scoop for public and private gitlab
update tests
update docs (brew, scoop, gitlab ci)

open questions

for @caarlos0 :)

Am I right in the assumption that it is possible to push to brew and scoop with skipping the release pipe?
I am not 100% happy by using the Extra field of artifact.Extra["GitLabFileUploadHash"] to pass around the hash I need to check if the file was already uploaded to the repo to reuse it in the brew/scoop pipe. (Yes github makes it easier and different) Would you suggest a new variable for this?

…upload hash from url

codecov-io · 2019-07-16T18:42:17Z

Codecov Report

Merging #1084 into master will decrease coverage by 1.94%.
The diff coverage is 42.23%.

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
- Coverage   83.51%   81.56%   -1.95%     
==========================================
  Files          57       57              
  Lines        2979     3109     +130     
==========================================
+ Hits         2488     2536      +48     
- Misses        411      494      +83     
+ Partials       80       79       -1

Impacted Files	Coverage Δ
pkg/config/config.go	`100% <ø> (ø)`	⬆️
pkg/context/context.go	`100% <ø> (ø)`	⬆️
internal/client/client.go	`50% <ø> (ø)`	⬆️
internal/client/github.go	`11.92% <0%> (ø)`	⬆️
internal/pipe/release/release.go	`90.12% <100%> (ø)`	⬆️
internal/tmpl/tmpl.go	`100% <100%> (ø)`	⬆️
internal/pipe/scoop/scoop.go	`91.75% <100%> (+3.11%)`	⬆️
internal/client/gitlab.go	`6% <11.76%> (+6%)`	⬆️
internal/pipe/brew/brew.go	`83.88% <94.28%> (+4.13%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e275e...ef25aed. Read the comment docs.

mavogel · 2019-07-19T07:58:06Z

ping @caarlos0 for some clarifications :) Then I'll move on in the next days

caarlos0 · 2019-07-20T16:09:59Z

internal/pipe/brew/brew.go

+					ctx.Config.GitLabURLs.Download,
+					ctx.Config.Release.GitLab.Owner,
+					ctx.Config.Release.GitLab.Name,
+					artifact.Extra["GitLabFileUploadHash"],


maybe use https://godoc.org/github.com/goreleaser/goreleaser/internal/artifact#Artifact.ExtraOr with some fake string?

in theory it will never happen, but will be easier to debug in case it does (better have a url with fake-hash-should-not-happen than just nil 🤔

or maybe handle it and fail earlier

caarlos0 · 2019-07-20T16:12:23Z

Am I right in the assumption that it is possible to push to brew and scoop with skipping the release pipe?

shouldn't be I think... if it allows it, its a bug we should probably handle 🤔

I am not 100% happy by using the Extra field of artifact.Extra["GitLabFileUploadHash"] to pass around the hash I need to check if the file was already uploaded to the repo to reuse it in the brew/scoop pipe. (Yes github makes it easier and different) Would you suggest a new variable for this?

I think the extra thing is OK for now...

mavogel · 2019-08-01T22:04:45Z

Unfortunately, adding the GitlabUploadHash to the artifact does not work properly. I think because a copy is passed and so artifact.SetUploadHash(fileUploadHash) is not reflected. I tried it with pointer but it did not work either.

Somehow I do not fully get what happens here: https://github.com/goreleaser/goreleaser/blob/master/internal/pipe/release/release.go#L111. Why artifact := artifact?

Good news are, that the brewfile generation works (https://gitlab.com/mavogel/homebrew-tab/blob/master/Formula/release-testing-program.rb) and scoop will be a piece of cake once the hash-passing-issue is solved 🎉

GitHub
goreleaser/goreleaser
Deliver Go binaries as fast and easily as possible - goreleaser/goreleaser

GitLab
Formula/release-testing-program.rb · master · Manuel Vogel / homebrew-tab
Just my homebrew tab testing

caarlos0 · 2019-08-02T13:52:02Z

Somehow I do not fully get what happens here: https://github.com/goreleaser/goreleaser/blob/master/internal/pipe/release/release.go#L111. Why artifact := artifact?

its to force a new variable, if you remove that line and run make lint it will give you a better explanation...

Good news are, that the brewfile generation works (https://gitlab.com/mavogel/homebrew-tab/blob/master/Formula/release-testing-program.rb) and scoop will be a piece of cake once the hash-passing-issue is solved 🎉

awesome!

GitHub
goreleaser/goreleaser
Deliver Go binaries as fast and easily as possible - goreleaser/goreleaser

GitLab
Formula/release-testing-program.rb · master · Manuel Vogel / homebrew-tab
Just my homebrew tab testing

caarlos0 · 2019-08-02T13:52:28Z

Unfortunately, adding the GitlabUploadHash to the artifact does not work properly. I think because a copy is passed and so artifact.SetUploadHash(fileUploadHash) is not reflected. I tried it with pointer but it did not work either.

and with the Extra thing?

mavogel · 2019-08-03T09:22:31Z

and with the Extra thing?

Tried it but the key in the map is not set and I get a panic. I assume that the artifact in the context cannot be modified cuz we pass it as a copy in the release pipe (where I actually set the new attribute). I still don't get it completely but maybe I'll introduce another var in the context to store the hash. But this is more a workaround. Any ideas how to do this in an elegant way?

caarlos0 · 2019-08-03T13:45:00Z

hmm, maybe we need to change this:

type Artifacts struct {
	items []Artifact
	lock  *sync.Mutex
}

to

type Artifacts struct {
	items []*Artifact
	lock  *sync.Mutex
}

?

Probably pass a pointer everywhere as well 🤔

mavogel · 2019-08-04T10:16:22Z

Probably pass a pointer everywhere as well

Yep did the trick 👍 Will add scoop, tests and merge with master ;)

mavogel · 2019-08-07T16:19:21Z

Update

Scoop got successfully added
Verified the release to private brew and scoop bucket 🎉

caarlos0

Overall looks good.

The pointer to Artifact thing I'll backport to master so this becomes easier to test/review :)

Furthermore I left 1 comment, but I didn't review it fully yet.

Thanks again for your awesome work BTW 🚀

caarlos0 · 2019-08-12T12:25:41Z

internal/artifact/artifact.go

+	Goarch     string
+	Goarm      string
+	Type       Type
+	UploadHash string


can we move this into Extra?

sure, I can do that :) Makes sense because it's a gitlab only thing. Maybe there will be more in the future for other vcs.

Yeap... its not documented anywhere, but my idea was to use extra for things that not common between all things...

caarlos0 · 2019-08-12T20:45:44Z

@mavogel can I fix the conflicts or you rather do it yourself? anyway is fine by me :D

(just trying to make myself useful here hehe)

mavogel · 2019-08-12T20:53:28Z

no worries, already on it...

mavogel · 2019-08-12T21:20:30Z

when I check the report I don't get why there was a negative change in internal/client/github.go 🤔

caarlos0

LGTM

awesome work @mavogel! Thanks so much!

what do you say we merge this and leave it on master for a few days?

caarlos0 · 2019-08-13T17:41:43Z

when I check the report I don't get why there was a negative change in internal/client/github.go 🤔

me neither, maybe some bug 🤔

mavogel · 2019-08-13T18:12:14Z

awesome work @mavogel! Thanks so much!

You're welcome :) This tool simplifies our automated release process so much and I learned quite some stuff on the way. So thanks to you!

what do you say we merge this and leave it on master for a few days?

Fine for me. Merge it and then the others can continue based on the latest master 🎉

caarlos0 · 2019-08-13T18:30:34Z

Awesome, merged!

Hopefully people help testing :D

github-actions · 2020-11-19T03:12:02Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

mavogel added 7 commits July 8, 2019 20:17

makes context tokentype a public var

e538aa8

passes artifacts object into client upload function. extracts gitlab …

60da138

…upload hash from url

adds gitlab url to brew config

cd3b41a

build brew formula depending on token type

cb41aa7

fixes client for release tests

f4a4720

fixes exiting brew tests

345a494

fixes scoop test with dummy client adaption

c7fae27

caarlos0 reviewed Jul 20, 2019

View reviewed changes

mavogel added 8 commits July 28, 2019 20:45

uses new artifact upload hash

35dac90

fixes brew usage

c96dbed

updates gitlab createFile for brew

3bc99c2

fixes logging for non-existing file in gitlab logging

260515b

fix: gitlab createFile

98a953d

fix: removes encoding from gitlab create and update file opts

496d81b

fix: gitlab upload and artifact set upload hash

1636273

fix: linter

ad2064e

changed artifact item to a pointer in ctx

950846a

mavogel added 3 commits August 4, 2019 20:22

docs: updates homebrew

27c55bf

feat: enables scoop for gitlab release

b1d0d28

fix: scoop panic for pointer access

7a99ef0

mavogel added 9 commits August 8, 2019 20:12

test: updates brew tests

6699e19

docs: updates homebrew

878a3a4

test: for token type not implemented for brew

6e8361a

tests: for multiple linux builds

b6fc99b

fix: build artifacts are pointer in scoop

12cd454

test: for scoop and gitlab

e4dfa66

test: for artifacts set upload hash

7c281f1

merges master and fixes tests

286aed5

adds missing files after adaption

bfe414c

mavogel marked this pull request as ready for review August 11, 2019 20:36

caarlos0 reviewed Aug 12, 2019

View reviewed changes

This was referenced Aug 12, 2019

refactor: pointer to artifact #1110

Merged

Gitea release support #1106

Closed

mavogel added 3 commits August 12, 2019 21:37

chore: removes and clarifies comments

4059bd3

fix: moves artifact upload hash to extra map

f2a34ce

adds comment why we initialize the extra map

764bd24

mavogel mentioned this pull request Aug 12, 2019

Failing to create/update release and publish artifacts on GitLab CE #1091

Closed

merges master

aabcdc6

caarlos0 approved these changes Aug 13, 2019

View reviewed changes

Merge branch 'master' into feat-full-gitlab-support

ef25aed

caarlos0 merged commit e92bbe3 into goreleaser:master Aug 13, 2019

mavogel deleted the feat-full-gitlab-support branch August 13, 2019 18:35

github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: full gitlab support for brew and scoop #1084

feat: full gitlab support for brew and scoop #1084

mavogel commented Jul 16, 2019 •

edited

Loading

codecov-io commented Jul 16, 2019 •

edited

Loading

mavogel commented Jul 19, 2019

caarlos0 Jul 20, 2019

caarlos0 commented Jul 20, 2019

mavogel commented Aug 1, 2019 •

edited by unfurl-links bot

Loading

caarlos0 commented Aug 2, 2019 •

edited by unfurl-links bot

Loading

caarlos0 commented Aug 2, 2019

mavogel commented Aug 3, 2019

caarlos0 commented Aug 3, 2019

mavogel commented Aug 4, 2019 •

edited

Loading

mavogel commented Aug 7, 2019

caarlos0 left a comment

caarlos0 Aug 12, 2019

mavogel Aug 12, 2019

caarlos0 Aug 12, 2019

caarlos0 commented Aug 12, 2019

mavogel commented Aug 12, 2019

mavogel commented Aug 12, 2019

caarlos0 left a comment

caarlos0 commented Aug 13, 2019

mavogel commented Aug 13, 2019

caarlos0 commented Aug 13, 2019

github-actions bot commented Nov 19, 2020

feat: full gitlab support for brew and scoop #1084

feat: full gitlab support for brew and scoop #1084

Conversation

mavogel commented Jul 16, 2019 • edited Loading

If applied, this commit will...

Why is this change being made?

Provide links to any relevant tickets, URLs or other resources

Steps

open questions

codecov-io commented Jul 16, 2019 • edited Loading

Codecov Report

mavogel commented Jul 19, 2019

caarlos0 Jul 20, 2019

Choose a reason for hiding this comment

caarlos0 commented Jul 20, 2019

mavogel commented Aug 1, 2019 • edited by unfurl-links bot Loading

caarlos0 commented Aug 2, 2019 • edited by unfurl-links bot Loading

caarlos0 commented Aug 2, 2019

mavogel commented Aug 3, 2019

caarlos0 commented Aug 3, 2019

mavogel commented Aug 4, 2019 • edited Loading

mavogel commented Aug 7, 2019

Update

caarlos0 left a comment

Choose a reason for hiding this comment

caarlos0 Aug 12, 2019

Choose a reason for hiding this comment

mavogel Aug 12, 2019

Choose a reason for hiding this comment

caarlos0 Aug 12, 2019

Choose a reason for hiding this comment

caarlos0 commented Aug 12, 2019

mavogel commented Aug 12, 2019

mavogel commented Aug 12, 2019

caarlos0 left a comment

Choose a reason for hiding this comment

caarlos0 commented Aug 13, 2019

mavogel commented Aug 13, 2019

caarlos0 commented Aug 13, 2019

github-actions bot commented Nov 19, 2020

mavogel commented Jul 16, 2019 •

edited

Loading

codecov-io commented Jul 16, 2019 •

edited

Loading

mavogel commented Aug 1, 2019 •

edited by unfurl-links bot

Loading

caarlos0 commented Aug 2, 2019 •

edited by unfurl-links bot

Loading

mavogel commented Aug 4, 2019 •

edited

Loading