Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minigrace can load the wrong version of a module at runtime #310

Open
apblack opened this issue Nov 9, 2019 · 0 comments
Open

minigrace can load the wrong version of a module at runtime #310

apblack opened this issue Nov 9, 2019 · 0 comments

Comments

@apblack
Copy link
Contributor

apblack commented Nov 9, 2019

Under the SHA-hashing scheme introduced to resolve #293, we are sure to find corresponding versions of source code and compiled code at compile time. But there is no guarantee that the correct version will be loaded at execution time, even if the same GRACE_MODULE_PATH is used.

I believe that the best way to resolve this issue is to include the SHA hash of the source file as an argument to minigrace.loadModule. In the browser, this argument would be ignored, but at the command line it would be used to select from the (possibly several) modules found on GRACE_MODULE_PATH, just as it is used at compile time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant