Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add s3 principal to iam policy attached to sqs in lambda-promtail terraform code #14619

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

mwimpelberg28
Copy link
Contributor

@mwimpelberg28 mwimpelberg28 commented Oct 25, 2024

What this PR does / why we need it:
This PR adds a necessary block to the JSON for the SQS queue's IAM policy. Without the principal block, this error is thrown and the code fails.

Error: creating S3 Bucket (mattw-promtail-bucket) Notification: operation error S3: PutBucketNotificationConfiguration, https response error StatusCode: 400, RequestID: Q98D335K5EG1AN2T, HostID: qfu+BijCmGektcXaonVEkmuVCHP9BSqCGOMsRny3N1evFCeN17CuJ1+dB83fGPm4rAJJIuiU8REDr6gM//hLUUEdGrM322+h, api error InvalidArgument: Unable to validate the following destination configurations

Which issue(s) this PR fixes:
Fixes #14618

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@mwimpelberg28 mwimpelberg28 requested a review from a team as a code owner October 25, 2024 14:02
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@JordanRushing JordanRushing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordanRushing JordanRushing merged commit db0889e into main Oct 28, 2024
60 checks passed
@JordanRushing JordanRushing deleted the mwimpelberg/lambda-promtail-tf-fix branch October 28, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lambda-promtail terraform fails to create sqs queue
3 participants