fix(blooms): Check length of tasks before accessing first element in slice #14634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <[email protected]>
salvacorts
approved these changes
Oct 29, 2024
salvacorts
reviewed
Oct 29, 2024
| // Not sure how this can happen, but there was a bug report | ||
| // https://github.com/grafana/loki/issues/14623 | ||
| if len(seriesByDay) == 0 { | ||
| stats.Status = labelSuccess |
There was a problem hiding this comment.
I wonder if we should add a log line here with context.
chaudum
added a commit
that referenced
this pull request
Nov 6, 2024
…slice (#14634) This PR adds a length check for the partitioned series before accessing the first element of the resulting slice. Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a length check for the partitioned series before accessing the first element of the resulting slice.
Which issue(s) this PR fixes:
Fixes #14623
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR