Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable kubectl validation #115

Closed
sh0rez opened this issue Nov 17, 2019 · 4 comments · Fixed by #186
Closed

Allow to disable kubectl validation #115

sh0rez opened this issue Nov 17, 2019 · 4 comments · Fixed by #186
Labels
component/cli Command Line Interface component/kubernetes Working with Kubernetes clusters good first issue Good for newcomers kind/feature Something new should be added

Comments

@sh0rez
Copy link
Member

sh0rez commented Nov 17, 2019

quoting @lawrencejones:

Worth considering if you want to enable other kubectl flags. Several popular libraries (I'm looking at you, cert-manager) currently require you to set --validate=false to apply the manifests. You could use jsonnet to make the vendored resources valid, but I think many people may want to follow the official docs?

We should allow to invoke kubectl with --validate=false by exposing that exact flag on the tk apply operation.

Note: This should be done after #111 is merged
@sh0rez sh0rez added good first issue Good for newcomers component/cli Command Line Interface component/kubernetes Working with Kubernetes clusters labels Nov 17, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the kind/feature Something new should be added label Nov 17, 2019
@sh0rez sh0rez added kind/enhancement Improve something existing kind/feature Something new should be added and removed kind/feature Something new should be added kind/enhancement Improve something existing labels Nov 17, 2019
@sh0rez sh0rez mentioned this issue Nov 17, 2019
Merged
@stale
Copy link

stale bot commented Dec 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 17, 2019
@stale stale bot closed this as completed Dec 24, 2019
@sh0rez sh0rez reopened this Dec 24, 2019
@stale stale bot removed the stale label Dec 24, 2019
@stale
Copy link

stale bot commented Jan 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 24, 2020
@sh0rez sh0rez removed the stale label Jan 24, 2020
@cezkuj
Copy link
Contributor

cezkuj commented Jan 24, 2020

I would like to pick it up. Seems like depending PR is merged so doesn't seem like there are any other blockers

@cezkuj cezkuj mentioned this issue Jan 27, 2020
Merged
sh0rez pushed a commit that referenced this issue Jan 27, 2020
@cezkuj @sh0rez
feat(cli): allow to disable kubectl validation (#186)
ba1a3af 
Adds --validate flag to tk apply, to allow invoking kubectl without schema validation (kubectl apply --validate=false)

Fixes #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/cli Command Line Interface component/kubernetes Working with Kubernetes clusters good first issue Good for newcomers kind/feature Something new should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): adding possiblity to disable schema validation for kubectl…
2 participants
@cezkuj @sh0rez